[PATCH] Add ndr_errstr

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Nov 11 22:28:17 GMT 2007


On Sun, Nov 11, 2007 at 10:22:21PM +0000, Jelmer Vernooij wrote:
> > +const char *ndr_errstr(enum ndr_err_code err)
> > +{
> > +	switch (err) {
> > +	case NDR_ERR_SUCCESS:
> > +		return "NDR_ERR_SUCCESS";
> > +		break;
> ^^ the break here after the return shouldn't be necessary.
> 
> Other than that, looks good.

.. except that some silly static analyzers require it.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20071111/d179c966/attachment.bin


More information about the samba-technical mailing list