[PATCH] Add ndr_errstr
Jelmer Vernooij
jelmer at samba.org
Sun Nov 11 22:42:09 GMT 2007
On Sun, Nov 11, 2007 at 11:28:17PM +0100, Volker Lendecke wrote:
> On Sun, Nov 11, 2007 at 10:22:21PM +0000, Jelmer Vernooij wrote:
> > > +const char *ndr_errstr(enum ndr_err_code err)
> > > +{
> > > + switch (err) {
> > > + case NDR_ERR_SUCCESS:
> > > + return "NDR_ERR_SUCCESS";
> > > + break;
> > ^^ the break here after the return shouldn't be necessary.
> > Other than that, looks good.
> .. except that some silly static analyzers require it.
Ah, I didn't know that - please disregard my comment. If it isn't in there yet,
I think this would be useful to have in the coding style docs.
Cheers,
Jelmer
More information about the samba-technical
mailing list