winbindd client connection status in 3.0.25

Jeremy Allison jra at samba.org
Thu May 31 06:33:42 GMT 2007


On Tue, May 29, 2007 at 02:04:16PM -0700, Herb Lewis wrote:
> The feature hasn't been dropped just the info is printed
> wrong. We now always print PID 0 instead of actual PID of the
> winbindd client. Seems like we lost an initialization of the
> value somewhere but I cannot see where it should have been done.
> Sending a SIGUSR2 on 3.0.8 did produce valid PIDs (except for
> the first one)
> 
> 3.0.8 log output at debug level 2 after SUGUSR2
> 
> winbindd status:
>         2 clients currently active
>         client list:
>                 pid 0, sock 20, rbl 0, wbl 0
>                 pid 4934, sock 23, rbl 0, wbl 0
> 
> 3.0.25 log output
> 
> winbindd status:
>         4 clients currently active
>         client list:
>                 pid 0, sock 22
>                 pid 0, sock 26
>                 pid 0, sock 25
>                 pid 0, sock 20

This should fix it. I'm on the road in Germany doing a talk
at Googe developer day so I can't test this right now, but
if it fixes it for you please check it in to all three branches.

Jeremy.
-------------- next part --------------
Index: nsswitch/winbindd.c
===================================================================
--- nsswitch/winbindd.c	(revision 23262)
+++ nsswitch/winbindd.c	(working copy)
@@ -320,6 +320,9 @@
 	if (state->mem_ctx == NULL)
 		return;
 
+	/* Remember who asked us. */
+	state->pid = state->request.pid;
+
 	/* Process command */
 
 	for (table = dispatch_table; table->fn; table++) {


More information about the samba-technical mailing list