comment doesn't match code

Jim McDonough jmcd at samba.org
Sun May 27 12:13:09 GMT 2007


On 5/25/07, Jeremy Allison <jra at samba.org> wrote:
>
> On Fri, May 25, 2007 at 12:31:30PM -0700, Herb Lewis wrote:
> > and remove the error check code
>
> I'd prefer to move the comment to the implementation
> in the vfs_module, and leave the check in the mainline
> code. At some point we might get a good kernel implementation
> and start to care....
>
Yes, please leave the check here.  Take a look at vfs_gpfs.c: it can send
back a bad return code for this op.


-- 
-------------------
Jim McDonough
Samba Team
jmcd at samba dot org


More information about the samba-technical mailing list