comment doesn't match code

Jeremy Allison jra at
Fri May 25 21:26:41 GMT 2007

On Fri, May 25, 2007 at 12:31:30PM -0700, Herb Lewis wrote:
> Didn't look at the implementation :-)
> So that also makes the
> if(ret_flock == -1 ){
> code that will never get executed.
> Might be better to just leave the comment here and just
> (void)SMB_VFS_KERNEL_FLOCK(fsp, fsp->fh->fd, share_access);
> and remove the error check code

I'd prefer to move the comment to the implementation
in the vfs_module, and leave the check in the mainline
code. At some point we might get a good kernel implementation
and start to care....

More information about the samba-technical mailing list