svn commit: samba r22700 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael,

> My main question is: Why did you not use the
> centry-infrastructure of winbindd_cache.c but do tdb_pack/unpack
> your own way? This integrates rather badly with the rest of
> the code and makes it more difficult to write a validation function
> for the new key (which is missing).

I used the tdb only for storage (as this is really a cache
entry) but should not expire.  The TRUSTDOMCACHE is not so
much a limited cache entry like the rest of wcache but it
more of an accumulation of information collected from multiple
enumeration requests.  Another tdb would simply clutter the
file system.

Also note that at least in winbindd_ads.c, the trusted_domains()
function no longer caches.






cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGRJaJIR7qMdg1EfYRAubnAJ4tglSWg3mjRfBjkFYOAjbykXFbzACgn7lI
yphPW20q74/ZzQPrKJYkBi4=
=zHCH
-----END PGP SIGNATURE-----