svn commit: samba r22700 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

[Michael Adam]

Jerry, 

I am currently working on the winbind cache tdb validation
code. And i stumble about the TRUSTDOMCACHE key you added
in this checkin. 

Therere already was a TRUSTDOMS key that stored the same
information except for the flags, trust attrs and type.

My main question is: Why did you not use the
centry-infrastructure of winbindd_cache.c but do tdb_pack/unpack
your own way? This integrates rather badly with the rest of
the code and makes it more difficult to write a validation function
for the new key (which is missing).

I am asking because I am sure you had deeper reasons to
proceed this way, I don't see with my somewhat superficial
understanding of the code.

Any enlightenment appreciated!

Cheers, Michael

On So, Mai 06, 2007 at 06:39:32 +0000, jerry at samba.org wrote:
> Author: jerry
> Date: 2007-05-06 18:39:31 +0000 (Sun, 06 May 2007)
> New Revision: 22700
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22700
> 
> Log:
> Add a simple wcache TRUSTDOM api for maintaing a complete
> list of trusted domains without requiring each winbindd process
> to aquire this on its own.  This is needed for various idmap 
> plugins and for dealing with different trust topoligies.
> 
> list_trusted_domain() patches coming next.
> 
> 
> 
> Modified:
>    branches/SAMBA_3_0/source/nsswitch/winbindd.h
>    branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c
>    branches/SAMBA_3_0_26/source/nsswitch/winbindd.h
>    branches/SAMBA_3_0_26/source/nsswitch/winbindd_cache.c
> 
> 
> Changeset:
> Sorry, the patch is too large (1033 lines) to include; please use WebSVN to see it!
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22700

-- 

i.A. Michael Adam

-- 
Michael Adam <ma at sernet.de>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE