TALLOC_ABORT

[simo]

Herb,

On Tue, 2007-05-08 at 13:08 -0700, Herb Lewis wrote:
> not quite true. It gets called from async_reply_recv in winbindd_dual.c.
> I was testing some possible changes in winbindd and I hit this code
> because of an error that hit the double free case but I got no messages
> and had to go to looking at the core file to find out where it errored.

I guess the this is actually a bug in both samba3 and samba4.

In samba4 I found this in include/includes.h:

#if 0
/* darn, we can't do this now that we don't link the ldb tools to all
the smb libs */
#define TALLOC_ABORT(reason) smb_panic(reason)
#endif


I guess this code was disabled at some point by mistake, we should have
redefined TALLOC_ABORT() in the ldb tools if this was relevant.

I also guess that when we re-merged talloc in samba3 and samba4 this
code was omitted by mistake.

Not sure how should we fix it.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org