TALLOC_ABORT

Herb Lewis hlewis at panasas.com
Tue May 8 20:08:09 GMT 2007


not quite true. It gets called from async_reply_recv in winbindd_dual.c.
I was testing some possible changes in winbindd and I hit this code
because of an error that hit the double free case but I got no messages
and had to go to looking at the core file to find out where it errored.

Jelmer Vernooij wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Herb Lewis wrote:
> 
>>Why is TALLOC_ABORT defined as follows?
>>
>>#ifndef TALLOC_ABORT
>>#define TALLOC_ABORT(reason) abort()
>>#endif
>>
>>You basically throw away reason so you have to look at the core
>>file to find out why it died. Shouldn't we have a DEBUG or something
>>to print reason before calling abort? Is this definition for the
>>standalone talloc? Did we miss defining it somewhere for samba?
> 
> This code is only used if talloc is built standalone. By default, Samba
> defines it to be smb_panic(reason).
> 
> Talloc's standalone build doesn't use DEBUG().
> 
> Cheers,
> 
> Jelmer
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iQCVAwUBRkDPpgy0JeEGD2blAQInVAQAlYdFJzIEZgAPgKDfwfI2D+QRl7s7T9uZ
> sHf5reDLF76qFE9wxm+FQGleN64CIh7iXwBQxp2OCDidomFaUDj6t5ZVr6MYHKnA
> Gr1vlNG4K1g/tWR9BT6FzmnEISwfNJWOgdL4nPX8kG+U9UMa5fHHfpWt1JkFWk5T
> TufGWJFO2nM=
> =WdSZ
> -----END PGP SIGNATURE-----


More information about the samba-technical mailing list