[Patch]Handle git/git-svn checkouts in mkversion.sh

Kai Blin kai at samba.org
Tue Jun 26 12:31:41 GMT 2007


On Tuesday 26 June 2007 13:45:41 simo wrote:
> >   Samba("3.0.27pre1-GIT-0bd4d99e-[SVN-SAMBA_3_0 at 23601]")
> >
> > I have noticed that mkversion.sh is newer in SAMBA_4_0 so
> > I'll merge it across nice you check this in.
>
> I guess there is no guarantee that the half hash you get from GIT will
> me always greater then the previous one. So in this case it is probably
> more advisable to add the date. The version is useful only if ti gives
> you a way to guess where in time it has been taken. A random hash makes
> it only unique but it is not otherwise useful imo.

The idea is more to have a unique tag for every revision. You can't use the 
committish for "greater than" type comparisons. That wasn't my intention. I 
don't think a timestamp is better in that respect.

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070626/60c37456/attachment.bin


More information about the samba-technical mailing list