svn commit: samba r23518 - in branches: SAMBA_3_0/source/lib SAMBA_3_0/source/smbd SAMBA_3_0_26/source/lib SAMBA_3_0_26/source/smbd

[Jeremy Allison]

On Sat, Jun 16, 2007 at 11:48:13AM +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2007-06-16 11:48:11 +0000 (Sat, 16 Jun 2007)
> New Revision: 23518
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23518
> 
> Log:
> Remove the silly assumption that string_replace requires a pstring.
> 
> Jeremy, I am always very confused about the different length arguments
> in convert_string and friends. Can you take a look at the change in
> string_replace and verify it's ok? Thanks!
> 
> While at it, remove the pstring limit for strhasupper and strhaslower.

Looks very good to me. Should help make several code paths
less brittle against change - thanks !

Jeremy.