svn commit: samba r23283 - in branches/SAMBA_3_0/source/nsswitch: .

[Jeremy Allison]

On Thu, May 31, 2007 at 11:55:40PM +0000, obnox at samba.org wrote:
> Author: obnox
> Date: 2007-05-31 23:55:37 +0000 (Thu, 31 May 2007)
> New Revision: 23283
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23283
> 
> Log:
> Use a temporary talloc context in ads:lookup_groupmem. 
> And clean up unused stuff at the end.
> Daringly, I use talloc_steal at some point, where it 
> appears natural to me.

Rather than using talloc_steal() here :

(*names)[*num_names] = talloc_steal(names, names_nocache[i]);

please talloc_move() instead, as that's what you're
actually doing.

It should look like :

(*names)[*num_names] = talloc_move(tmp_ctx, &names_nocache[i]);

as you should no longer be accessing names_nocache[i] after
the move.

Thanks,

	Jeremy.