svn commit: samba r23724 - in branches/SAMBA_3_0/source: include printing rpc_server smbd

[Jeremy Allison]

On Thu, Jul 05, 2007 at 04:26:29PM +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2007-07-05 16:26:27 +0000 (Thu, 05 Jul 2007)
> New Revision: 23724
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23724
> 
> Log:
> Reduce access to the global inbuf a tiny bit. Add a struct smb_request
> that contains some of the fields from the SMB header, removing the need
> to access inbuf directly. This right now is used only in the open file
> code & friends, and creating that header is only done when needed. This
> needs more work, but it is a start.
> 
> Jeremy, I'm only checking this into 3_0, please review before I merge it
> to _26.

+1 from me except the removal of this bit in smbd/nttrans.c. 
We need this as a placeholder to remember where to add the check
once we support SeSecurityPrivilege.

-#if 0
-	/* We need to support SeSecurityPrivilege for this. */
-	if ((access_mask & SEC_RIGHT_SYSTEM_SECURITY)) && 
-			!user_has_privileges(current_user.nt_user_token,
-				&se_security)) {
-		restore_case_semantics(conn, file_attributes);
-		return ERROR_NT(NT_STATUS_PRIVILEGE_NOT_HELD);
-	}
-#endif

Please merge to 3.0.26 !

Thanks,

	Jeremy.