svn commit: samba r23724 - in branches/SAMBA_3_0/source: include printing rpc_server smbd

[Volker Lendecke]

On Fri, Jul 06, 2007 at 02:23:07PM -0700, Jeremy Allison wrote:
> +1 from me except the removal of this bit in smbd/nttrans.c. 
> We need this as a placeholder to remember where to add the check
> once we support SeSecurityPrivilege.
> 
> -#if 0
> -	/* We need to support SeSecurityPrivilege for this. */
> -	if ((access_mask & SEC_RIGHT_SYSTEM_SECURITY)) && 
> -			!user_has_privileges(current_user.nt_user_token,
> -				&se_security)) {
> -		restore_case_semantics(conn, file_attributes);
> -		return ERROR_NT(NT_STATUS_PRIVILEGE_NOT_HELD);
> -	}
> -#endif

Ooops. Sorry, only meant to have this temporarily in. This
confused my emacs indentation code, it is wrong code if you
count the ()... I'll fix that.

> Please merge to 3.0.26 !

Will do, right now I'm trying to optimize the statcache a
bit. I think we can save quite a few strlen calls.

Thanks for the review!

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070706/27866a4e/attachment.bin