[patch] hide libsmbclient's private symbols

Derrell Lipman derrell.lipman at unwireduniverse.com
Tue Jul 3 14:41:08 GMT 2007


For some reason I don't have the original message in this thread.
Either I never received it, or it got marked as spam and has since
been deleted.  Thanks for pointing me to this!

I've reviewed the public interface to libsmbclient and I don't notice
any exceptions to the general rule of smbc_* symbols are public and
all others are local.  The public header file defines a number of
structures with different names, but that'll be included by
applications so they'll have what they need.

I've never used the loader features for specifying which are public
symbols and which are not, but assuming it works as claimed, the patch
certainly gets a +1 from me.


On 7/2/07, Gerald (Jerry) Carter <jerry at samba.org> wrote:
> Hash: SHA1
> James Peach wrote:
> > I just realized why this won't work.  On some platforms
> > the @SONAMEFLAG@ just becomes '#' and comments out the remainder
> > of the line.
> >
> >> What platforms does this happen on? SHLD_MODULE uses
> >> exactly the same trick and appears to work OK in the
> >> build farm.
> I've seen it pop up before and it is confusing in how
> it break.  Unresolved symbols.  I cannot remember the
> details right now.  AIX maybe when build pam_winbind.
> cheers, jerry
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> n4rx1sRDOQMv/KBAdsBVemo=
> =IHwz

More information about the samba-technical mailing list