remove doschar_table[] ?

Jeremy Allison jra at samba.org
Sun Dec 16 06:25:10 GMT 2007


On Sun, Dec 16, 2007 at 06:05:14AM +0000, simo wrote:
> 
> On Sun, 2007-12-16 at 00:35 +0100, Volker Lendecke wrote:
> > Hi, Simo!
> > 
> > Last time I did this you objected, but I forgot your
> > argument, sorry. Can you comment on the attached patchset?
> > (and push it if you agree?)
> 
> I think it had to do with performances, and the fact that the "slow"
> method is *really* slow.
> 
> But I have to get some sleep, will take a look tomorrow.

Yes, but the slow method is only invoked on setup *once*
and if valid.dat can't be mmaped. It's an initialization
cost so it's perfectly fine to pay it.

Jeremy.


More information about the samba-technical mailing list