svn commit: samba r24733 - in branches: SAMBA_3_2/source/lib SAMBA_3_2/source/torture SAMBA_3_2_0/source/lib SAMBA_3_2_0/source/torture

[Rafal Szczesniak]

On Tue, Aug 28, 2007 at 12:40:03PM +0000, gd at samba.org wrote:
> Author: gd
> Date: 2007-08-28 12:40:01 +0000 (Tue, 28 Aug 2007)
> New Revision: 24733
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24733
> 
> Log:
> Add support for storing DATA_BLOBs in gencache.tdb (including torturetest).
> 
> Mimir, please have a look. DATA_BLOBs will now just show up as "DATA_BLOB"
> values with "net cache list".

Looks fine to me.

One aesthetic note - couldn't this:

> + again:
> +	len = 0;
> +
> +	len += tdb_pack(buf+len, buflen-len, "fB",
> +			valstr,
> +			blob->length, blob->data);
> +
> +	if (len == -1) {
> +		goto out;
> +	}
> +
> +	if (buflen < len) {
> +		SAFE_FREE(buf);
> +		buf = SMB_MALLOC_ARRAY(unsigned char, len);
> +		if (!buf) {
> +			goto out;
> +		}
> +		buflen = len;
> +		goto again;
> +	}

be implemented as a loop ?


cheers,
-- 
Rafal Szczesniak
Samba Team member  http://www.samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20070830/30f81e26/attachment.bin