svn commit: samba r24789 - in branches/SAMBA_3_2/source/utils: .

Gerald (Jerry) Carter jerry at samba.org
Wed Aug 29 20:53:32 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

mimir at samba.org wrote:
> Author: mimir
> Date: 2007-08-29 19:55:13 +0000 (Wed, 29 Aug 2007)
> New Revision: 24789
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24789
...
> -int net_use_machine_password(void) 
> +int net_use_upn_machine_account(void) 
>  {
>  	char *user_name = NULL;
>  
> @@ -353,7 +353,6 @@
>  		exit(1);
>  	}
>  
> -	user_name = NULL;
>  	opt_password = secrets_fetch_machine_password(opt_target_workgroup, NULL, NULL);
>  	if (asprintf(&user_name, "%s$@%s", global_myname(), lp_realm()) == -1) {
>  		return -1;


Rafal,

I just noticed this naming.  Technically we are not using
the machine upn and by default machines don't have a upn.
Would you mind using something a bit clearer?  Thanks.

Also, please make sure this is merged to the SAMBA_3_2_0 branch.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG1dzLIR7qMdg1EfYRAumXAKDuAqK5wBnPWZZi232NBdh5s6yVdACeJgj5
/l2n+BlmJoqPmb2C5uzs9AA=
=HOsV
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list