[proof of concept] libwbclient.so

James Peach jorgar at gmail.com
Fri Aug 31 15:36:19 GMT 2007


On 31/08/2007, Gerald (Jerry) Carter <jerry at samba.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> James Peach wrote:
> > On 30/08/2007, Gerald (Jerry) Carter <jerry at samba.org> wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> James,
> >>
> >>> I like the idea. Some comments about the API ....
>
> New files and patch posted to
>   http://samba.org/~jerry/src/libwbclient/

looks pretty good, a few comments:
    - hardcode MAXSUBAUTHS to avoid binary compatibility issues if you
hit a preprocessor conflict
    - use the wbc prefix for the new structures and types
    - wbcErrorString() should return const char *

How about bundling lsa_SidType into struct domain_sid? That way
callers will always know what type of SID they are dealing with when
they pass it around.

-- 
James Peach | jorgar at gmail.com


More information about the samba-technical mailing list