Options/arguments smbd, nmbd winbindd

[David Collier-Brown]

   Excellent, thanks for the clarification, and the corrected conclusion.

--dave

Michael Adam wrote:
> Hi!
> 
> On Fri, Aug 17, 2007 at 10:48:48AM -0400, David Collier-Brown wrote:
> 
>>  This is actually an instance of the "controlled change" problem, one
>>where users need to take action, in this case by changing the smb.conf
>>file, to adapt to a change.
> 
> 
> Karolin's proposal is not about invalid options in smb.conf but
> about invalid command line options when invoking the daemons!
> 
> I think it is a good idea to have smbd and friends refuse from
> starting when invoked with unknown or incomplete (cmdline)
> parameters. There are two typical scenarios:
> 
> Usually, you have samba packaged by someone (a linux
> distributor say), and you start it by the start script provided.
> I guess it is not expecting too much from the provider to call
> the daemons correctly? 
> 
> If on the other hand you have a self compiled samba, you
> will not have a problem adapting your start script to match
> the newly installed version (in the unlikely case that the
> allowed cmdline parameters have changed with the new version).
> 
> So +1 from me for starting the daemons only with correct
> commandline. :-)
> 
> Cheers, Michael
> 
> 
>>Karolin Seeger wrote:
>>
>>>Hi list,
>>>
>>>smbd, nmbd and winbindd can be started with invalid options currently. 
>>>The first patch attached would be a possible solution.
>>>It contains an exit if an invalid option has been used. The main problem
>>>is, that existing setups with wrong options or missing arguments in start
>>>scripts will break (which is the right behaviour from my point of view).
>>>
>>>The second patch attached prints a warning if an invalid option is used.
>>>The daemon starts despite the warning. There will be no warning in the
>>>case of missing arguments (e.g. smbd -s without path to config file).
>>>(The patch contains only the smbd as an example. This would be the same for
>>>nmbd and winbindd.)
>>>
>>>What do you think is the right solution?
>>>Are there any other suggestions?
>>>
>>>Cheers,
>>>Karo
> 
> 

-- 
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
davecb at spamcop.net           |                      -- Mark Twain
(416) 223-5943