Volume ID

Jeremy Allison jra at samba.org
Mon Apr 16 22:42:00 GMT 2007


On Tue, Jan 16, 2007 at 09:04:29AM +1100, tridge at samba.org wrote:
> Volker,
> 
>  > Yep. As I would assume that this is not the most popular
>  > version I thought adding a hex-scanner would be a bit
>  > overkill.
> 
> The following patch would let us accept hex constants for all smb.conf
> integers, using a 0x prefix (we've used this in Samba4 for a long
> time).
> 
> Index: param/loadparm.c
> ===================================================================
> --- param/loadparm.c    (revision 20821)
> +++ param/loadparm.c    (working copy)
> @@ -2189,7 +2189,7 @@
>                 return (-1);
>         }
> 
> -       return atoi(s);
> +       return strtol(s, NULL, 0);
>  }
> 
>  /*******************************************************************

That's such a generically good idea it's time we
did the same :-).

Jeremy.


More information about the samba-technical mailing list