svn commit: samba r22202 - in branches/SAMBA_3_0/source/nsswitch: .

[Jeremy Allison]

On Fri, Apr 13, 2007 at 01:41:39PM +1000, tridge at samba.org wrote:
> 
> Did you really see problems like this with any tdb file? If so, can
> you please send me the tdb file?

No, no winbindd access will produce such a tdb file.

> tdb should be doing range checking on all offsets from the db. If it
> isn't, then we have a bug and should fix it. The range checking code
> is what triggers the tdb to grow automatically when needed, so it
> needs to be right even for non-corrupt databases.

I know - I did work on this code remember :-).

The issue some (real) customers are seeing is with laptops
(mainly I believe) going down hard - no shutdown. In that
case without the equivalent of an msync it's easy to get
a corrupted tdb state. Probably the real solution is to go
to a transactional tdb for this cache file, but I started
this code before transactional tdb existed and Volker
did ask me to finish it. I'd imagine the speed isn't
an issue but we should check.

Jeremy.