Fixed exclude_dir in the recycle vfs

Jeremy Allison jra at samba.org
Sun Apr 8 02:06:31 GMT 2007


On Fri, Apr 06, 2007 at 12:26:00PM +1000, Jon Gough wrote:
> Jeremy,
>    I cannot test this change as I get the following error
> 
> Apr  6 10:07:25 saturn smbd[3745]:   The module was compiled against 
> SMB_VFS_INTERFACE_VERSION 21,
> Apr  6 10:07:25 saturn smbd[3745]:   current SMB_VFS_INTERFACE_VERSION is 
> 16.
> Apr  6 10:07:25 saturn smbd[3745]:   Please recompile against the 
> current Samba Version!
> 
> I have installed samba.Version 3.0.24-3.fc6 from an RPM on my system. 
> I have checked out the latest Samba 3.0 release base and compiled 
> that. I have taken the recycle.so module from that and put it into 
> the samba runtime area. I have had to remove this due to the error 
> above. When will the version 21 of the interface be in the mainstream RPMs?
> 
> I presume your change is to make the system look for non-root 
> directories and exclude those, ie
> 
> recycle:exclude_dir = temp Downloads
> 
> will find directories like:
> 
> /temp
> /mydir/temp
> /mydir/Downloads
> 
> but as I cant test it currently what happens with
> 
> /temporary
> 
> Is this excluded as the root of the name is in the exclude list?
> 
> /mydir/temp/goodstuff
> 
> Is goodstuff ignored due to matching the 'temp' part of the path?

Actually the new code is much simpler than that.
It allows :

recycle:exclude_dir = temp Down*

A path with a component of "temp" or any
component starting with "Down" will match
the exclude list - all others will not.

Jeremy.


More information about the samba-technical mailing list