svn commit: samba r22020 - in branches/SAMBA_3_0/source: auth include lib smbd

[Andrew Bartlett]

On Tue, 2007-04-03 at 21:27 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Andrew Bartlett wrote:
> 
> > I think the getpwnam cache is now cleaner 
> > avoiding talloc_reference, and doing a tcopy_passwd instead.
> > Having a magic cache, using talloc_reference() I think
> > caused confusing behaviours.  Because callers
> > are not expecting a cache, they would be entirely 
> > within their rights to talloc_steal() parts of the the
> > results, but this would break the cache.
> 
> It's the stealing members from a structure that concerns me.
> 
> > The bug I was actually trying to fix is that I suspected 
> > that not everything was being cleaned up when a session
> > terminated.  I was hoping to make this simpler, with talloc
> > taking over from the manual cleanup system.
> 
> Has Jeremy chatted with you about this?  He was going to
> follow up.  

Yeah, haven't heard from him.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20070404/a629013e/attachment.bin