svn commit: samba r22020 - in branches/SAMBA_3_0/source: auth include lib smbd

[Andrew Bartlett]

On Mon, 2007-04-02 at 08:11 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> abartlet at samba.org wrote:
> > Author: abartlet
> > Date: 2007-04-02 03:46:13 +0000 (Mon, 02 Apr 2007)
> > New Revision: 22020
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22020
> > 
> > Log:
> > Make it more clear that both the vuser struct and it's contents are
> > talloc_free()'ed at the end of a session.
> > 
> > Rework the passwd cache code to use talloc_unlink and
> > talloc_reference, to more carefully manage the cache.
> 
> Are the calls to talloc_steal(), et. al really a good idea?
> Would you mind justifying why they are needed rather than
> the easier to debug dup() calls.  We've had discussions on
> list about avoiding them if possible in the Samba 3 tree.

Are you happier about these now we keep the cache as a copy?

The only talloc_steal left is to grab the specific member from the
result, and free the rest a couple of lines below, as commented. 

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20070404/145adaf1/attachment.bin