svn commit: samba r22020 - in branches/SAMBA_3_0/source: auth include lib smbd

Gerald (Jerry) Carter jerry at samba.org
Mon Apr 2 13:11:21 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

abartlet at samba.org wrote:
> Author: abartlet
> Date: 2007-04-02 03:46:13 +0000 (Mon, 02 Apr 2007)
> New Revision: 22020
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22020
> 
> Log:
> Make it more clear that both the vuser struct and it's contents are
> talloc_free()'ed at the end of a session.
> 
> Rework the passwd cache code to use talloc_unlink and
> talloc_reference, to more carefully manage the cache.

Are the calls to talloc_steal(), et. al really a good idea?
Would you mind justifying why they are needed rather than
the easier to debug dup() calls.  We've had discussions on
list about avoiding them if possible in the Samba 3 tree.




cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGEQD5IR7qMdg1EfYRAtX9AKDbz9nx8WGGVgWwIxW41MK/uC6tQACeLako
UYYUZOKj6IS+SBzrkOOzK1I=
=sluC
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list