Coverity errors in libndr/

[Andrew Bartlett]

On Tue, 2006-10-24 at 22:43 +0200, Volker Lendecke wrote:
> Hi, pidl gurus!
> 
> Coverity has discovered a class of flaws in the generated
> NDR marshalling code.
> 
> If you look at gen_ndr/ndr_echo.c:1166 we dereference
> r->in.foo1 but in line 1174 we check if that's NULL. So
> either the check in 1174 is unnecessary or should come
> before 1166. Foo1 in this case is a ref pointer, but a
> broken user of this API should not segfault I think, so I
> would tend to move the check to line 1166.
> 
> But this goes a bit beyond my pidl knowledge.
> 
> Comments?

I think we should segfault on invalid API usage.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20061025/8da164e9/attachment.bin