Coverity errors in libndr/

[Volker Lendecke]

Hi, pidl gurus!

Coverity has discovered a class of flaws in the generated
NDR marshalling code.

If you look at gen_ndr/ndr_echo.c:1166 we dereference
r->in.foo1 but in line 1174 we check if that's NULL. So
either the check in 1174 is unnecessary or should come
before 1166. Foo1 in this case is a ref pointer, but a
broken user of this API should not segfault I think, so I
would tend to move the check to line 1166.

But this goes a bit beyond my pidl knowledge.

Comments?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20061024/6d476eaa/attachment.bin