svn commit: samba r19163 - in branches/SAMBA_3_0/source/lib/ldb: common include ldb_tdb

simo idra at
Mon Oct 9 12:49:30 GMT 2006

On Mon, 2006-10-09 at 11:34 +0200, Stefan (metze) Metzmacher wrote:

>  I am not sure I'd like it without a good
> > explanation.
> - -       modstr = talloc_strdup_no_spaces((struct ldb_context *)mem_ctx,
> - -                                        string);
> needing hacks like this to get rid of compiler warnings is ugly!
> this patch also makes the api more consistant,
> each function should allocate on a given mem_ctx not on the ldb_context.
> It would be ugly if the caller would need a talloc_steal().

I am not concerned about talloc_steal(), we have that for a reason, but
the cast over there is just terrible! That's a good enough explanation,
go on please.


Simo Sorce
Samba Team GPL Compliance Officer
email: idra at

More information about the samba-technical mailing list