svn commit: samba r19163 - in branches/SAMBA_3_0/source/lib/ldb: common include ldb_tdb

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

simo schrieb:
> On Sat, 2006-10-07 at 10:24 +0000, metze at samba.org wrote:
>> Author: metze
>> Date: 2006-10-07 10:24:16 +0000 (Sat, 07 Oct 2006)
>> New Revision: 19163
>>
>> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19163
>>
>> Log:
>> pass always a mem_ctx to functions and a ldb_context where needed
>>
>> It would be nice if someone can merge that to samba4,
>> otherwise I'll merge that to samba4 on monday
> 
> Changing the functions prototype is a big change a lot of code in samba4
> use these functions,

this statement is just wrong:-)

it compiles fine without any changes outside lib/ldb/ in samba4.

 I am not sure I'd like it without a good
> explanation.

- -       modstr = talloc_strdup_no_spaces((struct ldb_context *)mem_ctx,
- -                                        string);

needing hacks like this to get rid of compiler warnings is ugly!

this patch also makes the api more consistant,
each function should allocate on a given mem_ctx not on the ldb_context.
It would be ugly if the caller would need a talloc_steal().

metze

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFKhe+m70gjA5TCD8RAsytAJ90CTZRBmVyywdc+e9E4ekjxQ6dyACfX0B0
cFz3mryAlcW6K5IFSrogse4=
=Eojf
-----END PGP SIGNATURE-----