More pidl issues in Samba 3
Gerald (Jerry) Carter
jerry at samba.org
Wed Oct 4 20:53:32 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Jelmer Vernooij wrote:
> No, they can be unique or full as well. Also, I think allocating twice
> in this case is ok. The special thing here is that we are doing
> conversions on these character strings - so the UTF-8 representation
> might be different in size while the UCS-2 representation isn't.
If the caller passes in a buffer, that buffer should be filled.
For example, the RegQueryValue() doesn't work right now because
the pidl client code does a pointer assignment and not a memcpy.
These structures should be deep copied and not rely on struct
assignment in my opinion.
I can live with the structure assignment if necessary but
the QueryValue() bug has to be fixed sometime.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical