[PATCH] avoid sleeping after rebinding an LDAP search request

[Guenther Deschner]

Hi Jerry,

On Wed, Mar 08, 2006 at 03:46:50PM -0600, Gerald (Jerry) Carter wrote:
> Guenther Deschner wrote:
> > Hi,
> > 
> > attached patch improves our behaviour when we have search referrals (esp.
> > in-directory referrals); we always applied our replication sleep mechanism
> > after rebinding a simple search query. We only ever need to sleep after
> > writing to LDAP. Correct ?
> 
> Yes.  That sounds right to me.  The LDAP_REQ_EXTENDED is probably
> not always needed in the strictest sense but unless you are hard coding
> checks for specific ext_ops it's probably good enough.

I was thinking about LDAP_REQ_EXTENDED as well. Esp. as the
LDAP_EXOP_MODIFY_PASSWD is a LDAP_REQ_EXTENDED request, so we definitely
need to sleep after a password change but LDAP_EXOP_START_TLS is a
LDAP_REQ_EXTENDED as well. So we would now sleep after each rebound
start_tls operation... Not so nice, but better what we have currently.

> The patch looks good to me.  I assume (without really looking closely
> into the original code) that a last rebind_time time of 0 disables
> the sleep() ?

Yep. That is the case.

Cheers,
Guenther
-- 
Günther Deschner                    GPG-ID: 8EE11688
Novell / SUSE LINUX                       gd at suse.de
Samba Team                              gd at samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20060308/a0e0eb2c/attachment.bin