svn commit: samba r13989 - in branches/SAMBA_3_0/source/rpc_parse: .

Jeremy Allison jra at samba.org
Wed Mar 8 17:36:04 GMT 2006


On Wed, Mar 08, 2006 at 10:30:28AM -0600, Gerald (Jerry) Carter wrote:
> Probably WERR_INSUFFIENT_BUFFER but we have to check the amount
> of required space before we can really reply.  IIRC a NULL RPC_BUFFER*
> is not an error.  Many of the Win32 spooler callers use this convention.
> The spoolsrv.exe just gets in the way and tries to optimize by sending
> an initial buffer that might be large enough in an effort to save a
> round trip.

Ok, looking closely at this one, if I revert the change in
the parse buffer code, and then add an explicit check (currently
missing) in rpcbuf_alloc_size for a null buffer this should
cover us - ok ?

Jeremy.


More information about the samba-technical mailing list