svn commit: samba r13989 - in branches/SAMBA_3_0/source/rpc_parse: .

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jerry, Jeremy,

Gerald (Jerry) Carter wrote:
> jra at samba.org wrote:
>>>Author: jra
>>>Date: 2006-03-07 20:52:43 +0000 (Tue, 07 Mar 2006)
>>>New Revision: 13989
>>>
>>>WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13989
>>>
>>>Log:
>>>Fix for Coverity bug #45 and associated spoolss RPC_BUFFER
>>>problems. Ensure that if the parse succeeds on UNMARSHALL
>>>we have a valid (although possibly empty) RPC_BUFFER returned.
>>>Jeremy.
> Jeremy, I think this is the wrong approach.  And yet just one more
> reason to move us to IDL.  
If there's anything I can do to get more of Samba 3 to use IDL for the
RPC code, please let me know. I'd be happy to work on converting some
more of the pipes, if there's somebody who's familiar with the current
code to comment on my code and help test it. I really think it's
important to share code between the 3 and 4 branches.

It's not like I have any moral objections against working on Samba 3... ;-)

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEDxykPa9Uoh7vUnYRAofDAJ9Iv3f3WrpOQhDkMqr0akBuq0jZ5QCbBZdC
2cw3njWI9Ybo0aWSEAGnv9M=
=a+qD
-----END PGP SIGNATURE-----