svn commit: samba r13770 - in branches/SAMBA_4_0/source/lib/util: .

[simo]

On Wed, 2006-03-01 at 15:02 +0000, metze at samba.org wrote:
> Author: metze
> Date: 2006-03-01 15:02:07 +0000 (Wed, 01 Mar 2006)
> New Revision: 13770
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=13770
> 
> Log:
> - do fsync() on the debug fd, as we do in samba3,
>   I have an report that smbd memory usage grows to 1,5 GB or more
>   without this...
> - make log_timestamp static

The fsync operation may cost us a lot in terms of performance.
Can we wrap it around an ifdef or other if statements (adding a conf
option like "sync debug") ?

The memory grow problem shows up only when we have a high debug level
for debugging purposes, non need to force an fsync on low debug level
working servers IMO.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org