svn commit: samba r16398 - in trunk/source/smbd: .
jra at samba.org
Tue Jun 20 16:04:46 GMT 2006
On Tue, Jun 20, 2006 at 11:49:17AM +0200, Volker Lendecke wrote:
> On Tue, Jun 20, 2006 at 02:38:34AM +0000, jra at samba.org wrote:
> > Fix Klocwork #11767 and drasticly simplify the
> > logic in smbd/process.c. All interested (Volker,
> > Jerry, James etc). PLEASE REVIEW THIS CHANGE.
> > The logic should be identical but *much* easier
> > to follow and change (and shouldn't confuse Klockwork :-).
> Ah, and while you're at it: Would it be ok to rename
> 'session_tag' to 'vuid'?
Actually no, that name was explcit. I didn't want to
get that confused at this point. At this point in the
code we might be in SHARE security where it definately
isn't a vuid and mustn't be confused with one.
Now we understand vuid's better it might be ok, but I
remember being very careful about that at the time
the code was first re-written (this code has *history* :-).
More information about the samba-technical