svn commit: samba r16410 - in branches/SAMBA_4_0/source/smb_server: . smb2

Jelmer Vernooij jelmer at samba.org
Tue Jun 20 09:59:31 GMT 2006


On Tue, 2006-06-20 at 09:57 +0000, metze at samba.org wrote:
> Author: metze
> Date: 2006-06-20 09:57:00 +0000 (Tue, 20 Jun 2006)
> New Revision: 16410
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16410
> 
> Log:
> remove some warnings of talloc_steal() usage without target
> I only commit this as this is used in a global macro
> 
> tridge: we should try to get rid of this warning without using
> 	(void)talloc_steal(ctx, ptr);
> 	everywhere!!!
I think we should really ask whether that return value is ever going to
be different from ptr. If it is, we should use the return value
everywhere; if it isn't we should probably drop the return value imho.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060620/9c299f88/attachment.bin


More information about the samba-technical mailing list