svn commit: samba r17246 - in branches: SAMBA_3_0/source/passdb SAMBA_3_0_23/source/passdb

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew,

>> Log:
>> BUG 3964: lower case username prior to getpwnam() call in smbpasswd
> 
> An interesting bit if history here.  If this is the 
> it of code I remember, this originally, called GetPwnam(),
> ie the 'try all cases' code.  I didn't like that,
> and I changed it to use the username as found
> in smbpasswd, on the theory that this would look up 
> the correct case.
> 
> Looking at the bug, I see it didn't deal with getting 
> the correct case in the first place...

I remember that code quite well.  But it is a little outdated.
We now normalize all user accounts to lower case when create
them and but preserve the case in passdb.  Unless someone
actually cries fowl, I'm not going to worry about it.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFExqKQIR7qMdg1EfYRAj94AJ98tV1BDCkL7+ceZILF3RSQC4CwZgCeJUw4
qVvjHR1sHtZ/ZC7kh214Rlc=
=fZph
-----END PGP SIGNATURE-----