[PATCH][SAMBA_4_0] modular services configuration
idra at samba.org
Wed Jul 19 12:35:38 GMT 2006
On Wed, 2006-07-19 at 11:45 +0200, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> simo schrieb:
> > Building on the patch sent last week and following some of the comments
> > made by metze I have changed the approach and now the service
> > configuration stuff is separated into run-time configurable modules, and
> > both an ldb and a "classic" (default) modules are provided.
> Hi Simo,
> I haven't looked at this in detail, but it looks better,
> however I think we should change the names,
> subsystem 'svconf' -> 'shares'
> struct svconf_obj -> share_context
> and the 'sobj' -> 'sctx'
uhmm I just chaned it the other way around, but it is easy to make a
change for these. I choosed svconf because the prefix "share" was
already used elsewhere in the code, and didn't want to make confusion.
> and the share_option_bool(), share_option_string_list() from the last
> patch were better then svconf_bool_option().
Well in English you say "a bool option" not "an option bool", so I
changed the name to seem more natural :)
> So we should talk about shares and not about services, as services is
> something different in samba4( ldap,smb,rpc,winsrepl,cldap are services)
> also you could make a lot of the functions static.
Yes, but that's something we can clean-up later when we are satisfied by
the basic logic and structure of the code.
Will try to address the problems you mentioned soon, are you ok if I
commit it to the tree when these problems are solved? Or do you prefer
to review the code again as a patch?
Tridge, any comment from you?
Samba Team GPL Compliance Officer
email: idra at samba.org
More information about the samba-technical