[PATCH][SAMBA_4_0] modular services configuration

Stefan (metze) Metzmacher metze at samba.org
Wed Jul 19 09:45:37 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

simo schrieb:
> Building on the patch sent last week and following some of the comments
> made by metze I have changed the approach and now the service
> configuration stuff is separated into run-time configurable modules, and
> both an ldb and a "classic" (default) modules are provided.

Hi Simo,

I haven't looked at this in detail, but it looks better,
however I think we should change the names,

subsystem 'svconf' -> 'shares'
struct svconf_obj -> share_context
and the 'sobj' -> 'sctx'

and the share_option_bool(), share_option_string_list() from the last
patch were better then svconf_bool_option().

So we should talk about shares and not about services, as services is
something different in samba4( ldap,smb,rpc,winsrepl,cldap are services)

also you could make a lot of the functions static.

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEvf9Bm70gjA5TCD8RAqAzAJwIEeiarIiM8B/SFz4olGUYuVyIYgCfSob3
uQuBameAQhxR4RWUWJPrxHw=
=w8n1
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list