r16787 -- remove fstrings and use talloc

Jeremy Allison jra at samba.org
Wed Jul 5 00:02:02 GMT 2006


On Tue, Jul 04, 2006 at 04:36:01PM -0700, Jeremy Allison wrote:
> I (finally) took a look at this code (the idmap). It's *horrible*.
> 
> This code currently is a disaster waiting to happen. I'm going
> to clean it up.

More insanity. ID_OTHER is #defined but never used anywhere.
What is ID_EMPTY for ? Where is it used ? Tell me why we are
mapping to anything other than user or group ?

ID_QUERY_ONLY|ID_CACHE_ONLY seem to be flags controlling
backend actions - can they not be taken care of by the
backends themselves ?

This code needs completely rewriting. That's probably
too much to do on the 4th of July but I'm taking a
chainsaw to this mess.

Jeremy.


More information about the samba-technical mailing list