Thankyou for your work on libnet

[Andrew Bartlett]

On Thu, 2006-01-12 at 16:23 +0100, Rafal Szczesniak wrote:
> On Fri, Jan 13, 2006 at 12:39:22AM +1100, Andrew Bartlett wrote:
> > Mimir,
> > 
> > I just wanted to write a quick note to thank you for your work on
> > libnet, and to apologies as I place my large boots around your work.  
> 
> No problem at all. I can't spend as much time as you on samba code,
> but surely I'd like to continue to check in my small incremental
> changes.

And please do.  The async work is very valuable, and the ejsnet code
saved me wondering where to start.  I work much faster from an existing
rough prototype (even if I rework it) than from a blank text editor...

> > I'm working hard towards the tech preview of Samba4, and moving more
> > into libnet, particularly as I work on making the join and vampire
> > process as easy as possible.
> > 
> > I see you have been quietly working here, on both libnet and on the ejs
> > bindings.  A number of times I have expected to start an area from
> > scratch, and instead find at least a groundwork.  I would only encourage
> > you to spend a bit of time to get these things into the standard
> > testsuites.   Hopefully then we won't break things as easily, and we
> > might also notice that things are there!  To that end, I've added the
> > NET-API tests to the standard testsuite.
> 
> Does that mean that I should consult with you all of the changes I'd like
> to make in the code ? I know you're trying to get samba4 preview of the
> surface and I agree there's a pressure on this. 

Review on the mailing list is always a good thing.  It is sometimes hard
to get folks attention, and I admit I've been a bit impatient in the
past few days, putting code up for review, then putting it in SVN
anyway...

libnet and the ejsnet code has now 'grown up', becoming key parts of
Samba4.  You should be proud, not shy.  Please keep up the work, because
this is important code.

I'm going to make a few changes to ejsnet, to allow the provision of an
existing cli_credentials struct, rather than needing to construct a new
one.  (The caller can then construct that, rather than passing
arguments).  I hope you will approve.

This is all with the aim of adding an 'Import Windows Domain' function
to Samba4's install page.  With inputs of 'domain, admin username,
password', we should be able to provision for, join and vampire a
windows domain from the SWAT GUI.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060113/8616758c/attachment.bin