[PATCH] unused argument in pdb_get_methods()
Jeremy Allison
jra at samba.org
Thu Feb 23 05:48:06 GMT 2006
On Thu, Feb 23, 2006 at 02:36:50PM +1100, Tim Potter wrote:
> There seems to be a bit of pdb hacking going around. I noticed just now
> that the (confusing) argument to pdb_get_methods() isn't set to anything
> other than False.
>
> Here's a patch to clean things up a bit.
Hmmm, ok - actually, sometimes it is set to True - called from
initialize_password_db() with the 'reaload' parameter passed
in. That arg is set to true in :
pam_smbpass/pam_smb_acct.c
pam_smbpass/pam_smb_passwd.c
web/swat.c
Now, are any of those actually needed.... I would guess not,
as it's also called with the reload parameter set to false
in :
smbd/server.c
utils/net.c
utils/pdbedit.c
utils/smbpasswd.c
and of course there's no real explaination of why it's one
way in pam_smbpass and the other way in utils/net.c....
Will the person who initially designed and coded this stand
up and explain ? :-) :-) :-).
Jermey.
More information about the samba-technical
mailing list