[PATCH] unused argument in pdb_get_methods()

Tim Potter tpot at samba.org
Fri Feb 24 02:54:44 GMT 2006


On Wed, 2006-02-22 at 21:38 -0800, Jeremy Allison wrote:
> On Wed, Feb 22, 2006 at 09:37:04PM -0800, Jeremy Allison wrote:
> > On Thu, Feb 23, 2006 at 02:36:50PM +1100, Tim Potter wrote:
> > > There seems to be a bit of pdb hacking going around.  I noticed just now
> > > that the (confusing) argument to pdb_get_methods() isn't set to anything
> > > other than False.
> > > 
> > > Here's a patch to clean things up a bit.
> > 
> > tpot - looks great to me. Please check into HEAD and SAMBA_3_0.
> 
> Other than you've missed one... :-). This also means that
> initialize_password_db() can lose the BOOL parameter also !

Except that some callers decide to set the reload parameter to True in
some cases.  Doh.  

I'll have to work on it some more.


Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060224/6f073073/attachment.bin


More information about the samba-technical mailing list