BUG 3518: [VFS vfs_extd_audit.c] Option for writing to syslog from vfs_extd_audit.c

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Olivier,

I'm not opposed to this patch but as a matter of style I would
rather not wrap the syslog statements in an if() statement
every time.  Take a look at sys_adminlog() in
http://viewcvs.samba.org/cgi-bin/viewcvs.cgi/branches/SAMBA_2_2/source/lib/system.c?rev=518&view=markup

Also, I'm not sure why you would not want to write to syslog.
That's the whole purpose of the module.  Your changes disable
a lot of the logging altogether.  Why not just specify a local
user and send that to a separate file (as you mention in BUG 2349).

Like I said, I'm not opposed, but I need to be sold on the
benefits of the patch a little bit more.  Right now, it seems
like adding an additional parameter to the configuration with
very little payback.



cheers, jerry
=====================================================================
I live in a Reply-to-All world                -----------------------
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFD9ITJIR7qMdg1EfYRAsXGAKDs9vOxMKYduenJ6XFZA4FY+uk/HwCgp5Hx
eiTeGsRjsqtEf+snTVOGIzc=
=NFMQ
-----END PGP SIGNATURE-----