infiniband: ?

tridge at samba.org tridge at samba.org
Mon Dec 4 23:27:57 GMT 2006


 > I had a quick look at how it works, and I can't see it doing anything
 > that should be rsh/ssh specific, but it also doesn't work, even for a
 > empty transfer (where the trees are already in sync). There must be
 > something in there I've missed :-)

The patch below fixes it so :: destinations work with rspush. I've
sent it to the maintainer.

Cheers, Tridge


--- /usr/share/python-support/bzrtools/bzrlib/plugins/bzrtools/bzrtools.py~     2006-11-28 12:04:34.000000000 +1100
+++ /usr/share/python-support/bzrtools/bzrlib/plugins/bzrtools/bzrtools.py      2006-12-05 10:15:25.000000000 +1100
@@ -249,6 +249,11 @@
     if push_location is None:
         raise BzrCommandError("No rspush location known or specified.")

+    if (push_location.find('::') != -1):
+        usessh=False
+    else:
+        usessh=True
+
     if (push_location.find('://') != -1 or
         push_location.find(':') == -1):
         raise BzrCommandError("Invalid rsync path %r." % push_location)
@@ -283,7 +288,7 @@
                 " specified location.  Please ensure that"
                 ' "%s" is of the form "machine:/path".' % push_location)
     print "Pushing to %s" % push_location
-    rsync(tree.basedir+'/', push_location, ssh=True,
+    rsync(tree.basedir+'/', push_location, ssh=usessh,
           excludes=final_exclusions)

     set_push_data(tree, push_location)


More information about the samba-technical mailing list