patch for missing ads_destroy calls in net_ads_join

Gerald (Jerry) Carter jerry at samba.org
Thu Aug 3 12:22:15 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Adam wrote:
> Hi,
> 
> this is a patch that fixes a couple of missing ads_destroy
> calls in utils/net_ads.c:net_ads_join.

Applying to SAMBA_3_0 and SAMBA_3_0_23 now.  The only thing
I changed was initialization to ensure that "ADS_STRUCT *ads = NULL"
so that if we call ads_destroy() on an error path before
we have called ads_startup(), we will exit without trying
to free invalid memory.




cheers, jerry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFE0ep3IR7qMdg1EfYRArZxAKCxYuMCjS+UAnjpXdPH5q73m1fiJwCgpalk
cQd+KC1Eu9OI3tDhRyVf7F8=
=krW8
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list