patch for missing ads_destroy calls in net_ads_join

Michael Adam ma at
Thu Aug 3 13:13:34 GMT 2006

On Thu, Aug 03, 2006 at 07:22:15AM -0500, Gerald (Jerry) Carter wrote:
> Michael Adam wrote:
> > Hi,
> > 
> > this is a patch that fixes a couple of missing ads_destroy
> > calls in utils/net_ads.c:net_ads_join.
> Applying to SAMBA_3_0 and SAMBA_3_0_23 now.  The only thing
> I changed was initialization to ensure that "ADS_STRUCT *ads = NULL"
> so that if we call ads_destroy() on an error path before
> we have called ads_startup(), we will exit without trying
> to free invalid memory.

Oh yes..., that escaped my attention. 

Thanks - Michael

More information about the samba-technical mailing list