svn commit: samba r11868 - in branches/SAMBA_4_0/source/torture/rpc: .

[Volker Lendecke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett writes:
> You do a network, rather than an interactive samlogon.  I would also

Ok, I think I can live with that.... It's the logon_level parameter?

> like it if the 'auth2' code was a generic composite function, tied into
> the rpc bind (like the old sync code was).  But I understand that
> getting the matching layering with the XP login makes this difficult. 

In particular as the EPM stuff is not async yet. I'm not after matching 100%
of the packets (this machine uses read/write instead of trans calls for RPC),
I'm after putting as realistic RPC load on the PDC as possible. If this means
using slightly different calls I'm fine.

> Oh, and we both know it needs comments. :-)

To be honest, what is the point of putting

/*
  Receive an schannel'ed netlogon bind
*/
static void xp_login_recv_schannel(struct composite_context *creq)

right before that routine? It might sound lazy and probably is, but I think as
the individual steps are more like descriptive goto targets these days I don't
really see the point in these one-liners.

What I fully agree to is a comment on the "big" picture of the operations this
thing does.

Volker
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFDhVlmUROFNttXCWYRAr5WAKDRbD33VhZnw7QmZ+B2KWGP58TNJwCfb/iz
Ymh2Y+nVY1/O6jzT9Mwk+2U=
=g9TG
-----END PGP SIGNATURE-----