EOT :-) [was Re: svn commit: samba r6127 - in branches/SAMBA_3_0/source: ...]

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett wrote:
|> Eliminated all compiler warnings pertaining to mismatched
"qualifiers".  The
|> whole of samba comiles warning-free with the default compiler flags.
|
| However, when you compile --enable-developer, these all come back again,
| just different :-)
|
| Sorry to jump on the new guy, but const issues have been gone over many
| times, and they are not easy unless you start fooling the compiler - see
| the discard_const_p() macro from Samba4 to do it reliably.
|
| The current situation was pretty much the minimum warnings we could get
| without invoking discard_const_p(), and already used a similar trick in
| tdb.

Andrew's correct.  Sorry Derrell.

ok.  executive decision time.  I here by decree that all developers
run with --enable-developer.  I don't mind even enabliing this by
default in SAMBA_3_0 and trunk.   But we will not set this by default
in the release tarballs.


cheers, jerry



btw....we're not warning free yet :-)    probably some more showing up
in gcc 3.4


libsmb/clikrb5.c: In function `krb5_princ_component':
libsmb/clikrb5.c:529: warning: assignment discards qualifiers from
pointer target type
libsmb/clispnego.c: In function `spnego_gen_negTokenTarg':
libsmb/clispnego.c:341: warning: cast discards qualifiers from pointer
target type
passdb/pdb_get_set.c: In function `pdb_set_plaintext_passwd':
passdb/pdb_get_set.c:1198: warning: cast discards qualifiers from
pointer target type
lib/access.c: In function `client_match':
lib/access.c:136: warning: cast discards qualifiers from pointer target type
lib/util_str.c: In function `next_token':
lib/util_str.c:48: warning: cast discards qualifiers from pointer target
type
lib/util_str.c: In function `toktocliplist':
lib/util_str.c:112: warning: cast discards qualifiers from pointer
target type
lib/util_str.c:135: warning: cast discards qualifiers from pointer
target type
Compiling lib/clobber.c
lib/util_str.c: In function `strchr_m':
lib/util_str.c:1224: warning: cast discards qualifiers from pointer
target type
lib/util_str.c:1241: warning: cast discards qualifiers from pointer
target type
lib/util_str.c: In function `strrchr_m':
lib/util_str.c:1278: warning: cast discards qualifiers from pointer
target type
lib/util_str.c:1297: warning: cast discards qualifiers from pointer
target type
lib/util_str.c: In function `strnrchr_m':
lib/util_str.c:1318: warning: cast discards qualifiers from pointer
target type
lib/util_str.c: In function `strstr_m':
lib/util_str.c:1337: warning: cast discards qualifiers from pointer
target type
lib/util_str.c:1354: warning: cast discards qualifiers from pointer
target type
lib/util_str.c:1395: warning: cast discards qualifiers from pointer
target type
lib/util_uuid.c: In function `smb_string_to_uuid':
lib/util_uuid.c:97: warning: cast discards qualifiers from pointer
target type
Compiling lib/util_file.c
lib/util_unistr.c: In function `strchr_w':
lib/util_unistr.c:401: warning: cast discards qualifiers from pointer
target type
lib/util_unistr.c:404: warning: cast discards qualifiers from pointer
target type
lib/util_unistr.c: In function `strrchr_w':
lib/util_unistr.c:425: warning: cast discards qualifiers from pointer
target type
lib/util_unistr.c: In function `strnrchr_w':
lib/util_unistr.c:446: warning: cast discards qualifiers from pointer
target type
lib/util_unistr.c: In function `strstr_w':
lib/util_unistr.c:464: warning: cast discards qualifiers from pointer
target type
lib/util_unistr.c: In function `strpbrk_wa':
lib/util_unistr.c:735: warning: cast discards qualifiers from pointer
target type
lib/util_unistr.c: In function `strstr_wa':
lib/util_unistr.c:750: warning: cast discards qualifiers from pointer
target type
sswitch/wb_common.c: In function `winbind_off':
nsswitch/wb_common.c:609: warning: initialization discards qualifiers
from pointer target type
nsswitch/wb_common.c: In function `winbind_on':
nsswitch/wb_common.c:616: warning: initialization discards qualifiers
from pointer target type
intl/lang_tdb.c: In function `lang_msg_free':
intl/lang_tdb.c:234: warning: cast discards qualifiers from pointer
target type
intl/lang_tdb.c: In function `lang_msg_rotate':
intl/lang_tdb.c:251: warning: cast discards qualifiers from pointer
target type
tdb/tdbutil.c: In function `make_tdb_data':
tdb/tdbutil.c:46: warning: cast discards qualifiers from pointer target type
tdb/tdbutil.c: In function `tdb_chainlock_with_timeout_internal':
tdb/tdbutil.c:65: warning: cast discards qualifiers from pointer target type
smbd/oplock_linux.c: In function `set_capability':
smbd/oplock_linux.c:85: warning: implicit declaration of function `capget'
smbd/oplock_linux.c:92: warning: implicit declaration of function `capset'
smbd/oplock_linux.c: In function `linux_oplock_receive_message':
smbd/oplock_linux.c:136: warning: cast discards qualifiers from pointer
target type
smbd/oplock_linux.c:136: warning: cast discards qualifiers from pointer
target type
smbd/notify_kernel.c: In function `kernel_check_notify':
smbd/notify_kernel.c:104: warning: cast discards qualifiers from pointer
target type
smbd/notify_kernel.c:104: warning: cast discards qualifiers from pointer
target type
smbd/notify_kernel.c: In function `kernel_remove_notify':
smbd/notify_kernel.c:132: warning: cast discards qualifiers from pointer
target type
smbd/notify_kernel.c:132: warning: cast discards qualifiers from pointer
target type
auth/pampass.c: In function `make_pw_chat':
auth/pampass.c:224: warning: passing arg 1 of `next_token' from
incompatible pointer type
auth/pampass.c:235: warning: passing arg 1 of `next_token' from
incompatible pointer type
libads/ldap.c: In function `ads_do_paged_search':
libads/ldap.c:484: warning: assignment discards qualifiers from pointer
target type
libads/ldap.c:489: warning: assignment discards qualifiers from pointer
target type
libads/ldap.c:492: warning: assignment discards qualifiers from pointer
target type
libads/ldap.c: In function `ads_gen_mod':
libads/ldap.c:965: warning: initialization discards qualifiers from
pointer target type
libads/ldap_printer.c: In function `ads_find_printers':
libads/ldap_printer.c:65: warning: assignment discards qualifiers from
pointer target type
libads/sasl.c: In function `ads_sasl_gssapi_bind':
libads/sasl.c:288: warning: initialization discards qualifiers from
pointer target type
libads/kerberos.c: In function `kerberos_kinit_password':
libads/kerberos.c:92: warning: cast discards qualifiers from pointer
target type
lib/smbldap.c: In function `free_attr_list':
lib/smbldap.c:270: warning: cast discards qualifiers from pointer target
type
Compiling smbd/server.c
lib/smbldap.c: In function `smbldap_search':
lib/smbldap.c:1069: warning: cast discards qualifiers from pointer
target type
lib/smbldap.c: In function `smbldap_check_root_dse':
lib/smbldap.c:1474: warning: cast discards qualifiers from pointer
target type
web/neg_lang.c: In function `qsort_cmp_list':
web/neg_lang.c:57: warning: cast discards qualifiers from pointer target
type
web/neg_lang.c:58: warning: cast discards qualifiers from pointer target
type
nsswitch/winbindd_util.c: In function `fill_domain_username':
nsswitch/winbindd_util.c:639: warning: cast discards qualifiers from
pointer target type
nsswitch/winbindd_rpc.c: In function `get_ldap_seq':
nsswitch/winbindd_rpc.c:792: warning: cast discards qualifiers from
pointer target type
utils/net_ads.c: In function `net_ads_lookup':
utils/net_ads.c:84: warning: cast discards qualifiers from pointer
target type
utils/net_ads.c: In function `net_ads_password':
utils/net_ads.c:1171: warning: cast discards qualifiers from pointer
target type
utils/net_lookup.c: In function `net_lookup_kdc':
utils/net_lookup.c:196: warning: cast discards qualifiers from pointer
target type
client/smbspool.c: In function `main':
client/smbspool.c:151: warning: assignment discards qualifiers from
pointer target type
client/smbspool.c:156: warning: assignment discards qualifiers from
pointer target type
utils/smbcontrol.c: In function `do_printnotify':
utils/smbcontrol.c:431: warning: cast discards qualifiers from pointer
target type
libsmb/spnego.c: In function `read_negTokenInit':
libsmb/spnego.c:50: warning: cast discards qualifiers from pointer
target type
libsmb/spnego.c: In function `read_negTokenTarg':
libsmb/spnego.c:185: warning: cast discards qualifiers from pointer
target type
libsmb/spnego.c: In function `free_spnego_data':
libsmb/spnego.c:320: warning: cast discards qualifiers from pointer
target type
libsmb/spnego.c:329: warning: cast discards qualifiers from pointer
target type
......




-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCSyUPIR7qMdg1EfYRAgn9AKCWkmY3r9hwlZUYK77QMLQY3IKHNACfcjSi
5hVGG/wLqwhL+1G/V4/+1tg=
=GPdy
-----END PGP SIGNATURE-----